Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub#486 - Fix connection pool leaks #504

Merged
merged 6 commits into from
Oct 29, 2019
Merged

GitHub#486 - Fix connection pool leaks #504

merged 6 commits into from
Oct 29, 2019

Conversation

OwenLindsell
Copy link
Contributor

No description provided.

@OwenLindsell OwenLindsell changed the title Fix connection pool leaks GitHub#486 - Fix connection pool leaks Oct 25, 2019
dvlato
dvlato reviewed Oct 28, 2019
View reviewed changes
Copy link
Contributor

@dvlato dvlato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues mentioned fix. Waiting for a second review and if possible some tests.

@dvlato dvlato self-requested a review October 28, 2019 10:57
@OwenLindsell OwenLindsell force-pushed the github486-fix-connection-pool-leak branch from fdeb1b5 to 6db167c Compare October 29, 2019 15:17
@OwenLindsell OwenLindsell marked this pull request as ready for review October 29, 2019 15:33
@OwenLindsell OwenLindsell merged commit 5701d81 into ExpediaGroup:master Oct 29, 2019
@OwenLindsell
Copy link
Contributor Author

Fixes #486

@OwenLindsell OwenLindsell mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvlato dvlato Awaiting requested review from dvlato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OwenLindsell @dvlato